add spec for liveview option to OpentelemetryPhoenix #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryannaegele
approved these changes
Jan 16, 2025
bryannaegele
added
scope-ci
opentelemetry_phoenix
and removed
opentelemetry_phoenix
labels
|
@kenichi you'll have to rebase this yourself since you didn't allow maintainer edit |
kenichi
force-pushed
the
liveview_spec
branch
from
bcb9d75 to
1b64eee
Compare
|
@bryannaegele ah yes, of course. should be done now. |
|
looks like #448 fixes the tests that are failing here, i can rebase again after it's merged |
|
This appears to be an issue isolated to OTP 27.2. Tests consistently pass on the OTP 25 tests. We'll just force the merge. |
|
Pretty sure it's a race condition due to telemetry being stopped after each test (telemetry is already started in the supervision tree so shouldn't be necessary to start and stop it): #448 Not sure what exactly was changed in OTP 27 to cause this. |
gugahoa
pushed a commit
to gugahoa/opentelemetry-erlang-contrib
that referenced
this pull request
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
very slight spec update to keep dialyzer happy when one calls
OpentelemetryPhoenix.setup(liveview: true)before:
after: